Refactor MLLabelUtils to reflect obsdim changes in LearnBase.jl #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2021
|
So far the change on the test suits looks good to me. Given how verbose @Evizero wrote the test suit, I'm confident about the changes on |
|
Hi, what is the status of this? Can I help with it somehow? |
|
@darsnack I pushed commit which makes all tests pass with |
|
Looks good to me! |
darsnack
force-pushed
the
darsnack/refactor
branch
from
0a1cb8f to
cf9847c
Compare
racinmat
force-pushed
the
darsnack/refactor
branch
from
cf9847c to
3e475af
Compare
|
Closing in favor of #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates MLLabelUtils to reflect the changes to obsdim in JuliaML/LearnBase.jl#44.
I have tried to restrict my refactor as much as possible to only reflect changes necessary for obsdim. I do think this repo deserves another refactor pass just for re-org/clean-up, but I think that should be part of a future PR. I gotta thank @Evizero for some absolutely fantastic tests. I do not think it would have been possible to do this refactor without introducing dispatch bugs without such a comprehensive test suite.
I also moved a bunch of interface prototypes from MLLabelUtils to LearnBase. They were marked with a comment "move to LearnBase."
I am marking this PR as a draft, because it will be merged only after we release a new LearnBase.jl. I'm preparing it right now so that we can verify that all the downstream packages (e.g. MLDataPattern and MLLabelUtils) still work correctly with the new interface.
cc @juliohm @johnnychen94