Skip to content

Remove redundant operator definitions #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Mar 5, 2025

!= should be covered by the == definition above, and the other equality operators all fall back to <, so only define < (and <= for 1.6 and 1.7).

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.77%. Comparing base (f762420) to head (0f527db).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   72.10%   72.77%   +0.66%     
==========================================
  Files           3        3              
  Lines         190      191       +1     
==========================================
+ Hits          137      139       +2     
+ Misses         53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christiangnrd

This comment was marked as outdated.

@oscardssmith oscardssmith merged commit 829251b into JuliaMath:master Mar 25, 2025
10 checks passed
@christiangnrd christiangnrd deleted the redundant branch March 25, 2025 15:44
@christiangnrd
Copy link
Contributor Author

Thank you @oscardssmith for taking the time to for review and merge! Can we tag a release? No bump needed since the repo was bumped to 0.5.1 back in september and never registered. It would also close #90.

@oscardssmith
Copy link
Member

will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants