Hgh Cleanup #1075
Merged
Hgh Cleanup #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far all looks good to me. Happy to merge this if you want to do this in multiple PRs, but you can also do it in one go ... as you wish. |
|
I think I'll do a separate PR for the next steps since it'll be a bit more complicated for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of probably a few iterations for #1064
I mostly changed basic things, some naming and such, and some references to hgh vs gth pseudopotentials. The next step in my mind would be to make a duplicate file of
src/pseudo/PspHgh.jlcalled PspGth with all the same functionality, and update load_psp.jl accordingly, rerouting most loading through that. Then just putting warnings throughout PspHgh so if anyone is loading .hgh files (like from the data folder) there is a warning.In the whole I'm still unfamiliar with both github and the process of deprecation, so let me know if theres stuff I should be doing, best practices I'm missing, and also advice on if these next steps are pertinent right now, or if they're even reasonable thought processes.