Skip to content

Add LLVM libunwind v12.0.1 #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Add LLVM libunwind v12.0.1 #3504

merged 3 commits into from
Aug 21, 2021

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan ararslan requested a review from giordano August 17, 2021 04:44
@ararslan ararslan marked this pull request as draft August 17, 2021 05:47
@ararslan ararslan force-pushed the aa/llvm-libunwind-12.0.1 branch 2 times, most recently from 35eccc7 to 2e888ec Compare August 21, 2021 03:24
@ararslan
Copy link
Member Author

[03:26:00] CMake Error at CMakeLists.txt:2 (message):
[03:26:00]   libunwind requires being built in a monorepo layout with libcxx available

UGH. This apparently wasn't the case for libunwind 11 based on #2360, #2557, and #2570. I'm guessing what will need to happen is to use LLVM_full as a BuildDependency, build libcxx first in the script, then build libunwind. But if libunwind 12 actually needs to link to libc++, I would imagine we'd need a separate libcxx build recipe that would then be a Dependency for libunwind.

@ararslan
Copy link
Member Author

Wait what, llvm/llvm-project@8c03fdf I think it only needs libcxx and the monorepo so it can reuse one CMake file?!

@ararslan ararslan force-pushed the aa/llvm-libunwind-12.0.1 branch from 6168f03 to 79b391c Compare August 21, 2021 17:10
@ararslan ararslan force-pushed the aa/llvm-libunwind-12.0.1 branch from 79b391c to 65bd2f2 Compare August 21, 2021 17:15
@ararslan ararslan marked this pull request as ready for review August 21, 2021 17:18
@ararslan
Copy link
Member Author

Things seem to be working now. I worked around the build system change by straight up reverting the commit that touched it. A better long-term solution would of course be to properly adjust how we build it here, buuuuuuuuuut...

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super happy about reverting a commit, but might be good as a temporary solution

@ararslan
Copy link
Member Author

yolo

@ararslan ararslan merged commit ac1a560 into master Aug 21, 2021
@ararslan ararslan deleted the aa/llvm-libunwind-12.0.1 branch August 21, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants