Implement GL_EXT_bfloat16 #3905
Conversation
|
The spirv-tools support has landed. I've rebased and updated the deps, this is ready for review now. Ping @jeremy-lunarg @arcady-lunarg. |
| addExtension(spv::E_SPV_KHR_bfloat16); | ||
| addCapability(CapabilityBFloat16TypeKHR); | ||
|
|
||
| #if 0 |
There was a problem hiding this comment.
Is there any plan to add the necessary support to the debuginfo spec? Also, have you tested this extension with debuginfo enabled to make sure it at least successfully fails to emit debuginfo?
There was a problem hiding this comment.
I don't personally have any plans to do a followon debuginfo extension. It seems like it wasn't made extensible enough to support new types it didn't foresee. I tried running the bfloat16 unit test with debuginfo and it asserts here:
Id Builder::makeDebugFunctionType(Id returnType, const std::vector<Id>& paramTypes)
{
assert(debugId[returnType] != 0);
So, yeah, debuginfo may not work. But I'm not sure what to do about it.
There was a problem hiding this comment.
I should add - that test did run to completion (in release), generates code, but that code fails validation.
There was a problem hiding this comment.
In the interests of getting this done, I would say it's okay to not deal with debuginfo for now and open a glslang issue for the assertion failure.
There was a problem hiding this comment.
OK, I filed #3925 about this.
Edit: spirv-tools has landed, this is ready for review.
Spec is at KhronosGroup/GLSL#279