Warnings and warn on angle defaults #7502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nrc
force-pushed
the
nrc-warn-attr
branch
2 times, most recently
from
0a4a0ea to
6b29456
Compare
CodSpeed Instrumentation Performance ReportMerging #7502 will not alter performanceComparing Summary
|
nrc
force-pushed
the
nrc-warn-attr
branch
2 times, most recently
from
1a91290 to
1be094d
Compare
nrc
force-pushed
the
nrc-warn-attr
branch
2 times, most recently
from
64b7c34 to
349544a
Compare
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
jtran
reviewed
Jun 26, 2025
| preComments: [], | ||
| commentStart: 0, | ||
| let sufStr | ||
| switch (suffix) { |
There was a problem hiding this comment.
I explicitly made format_number_literal() and exposed it to TS so that we don't spread the units all over and separate the definition of the type from how it's converted to a string. What's the reason for not using that?
| break | ||
| case 'Unknown': | ||
| sufStr = '_?' | ||
| break |
There was a problem hiding this comment.
If you ever do switch on an enum in TS, you should enforce the exhaustive match. Search the codebase for "exhaustiveCheck" to see how it's done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two PRs in one, sorry!
Part one allows to allow/deny warnings using an attribute. There's a few follow-ups required for this. I'll file some issues soon. In particular, this only applies to warnings generated during execution, not parsing.
Part two adds a new warning for using numbers as angles without an explicit suffix (e.g., using
90instead of90deg). The intention with this is to make it less common to hit units issues with PI by discouraging AI and users from using math to convert between degrees and radians (and use implicit or explicit conversion instead). Long-term, I hope to make this a hard error in order to improve our units system, but since that is a breaking change, we'll need this warning for a long while first.As part of this change I have modified the frontend to always use suffixes with angles. However, I am very unsure that I have done this very well or completely, so please give a close review to the frontend parts.