Skip to content

Animate using a KCL function #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Animate using a KCL function #7600

wants to merge 1 commit into from

Conversation

jtran
Copy link
Contributor

@jtran jtran commented Jun 24, 2025

Things left before merging:

  • Decide on the API. Is the KCL function really required to be called animate() or should there be an annotation or something else that allows you to use any function, with options, like customizing the timer interval. Convention over configuration would say to use a specific name. Consider other APIs and prior art, e.g OpenSCAD.
  • Decide on what the button text and icon should be. Play/pause could be confused with run (i.e. execute) which often uses a play icon.
  • Fix cancellation, switching files, and execution errors to always clean up timers.
  • Display KCL errors from running the animate function?
  • Documentation
  • Pause icon (or equivalent) while playing

Copy link

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 11:55pm

Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #7600 will degrade performances by 69.86%

Comparing jtran/animate (bfefa0f) with main (c7f0a6c)

Summary

❌ 1 regressions
✅ 84 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
parse_car-wheel-assembly 2.3 ms 7.5 ms -69.86%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant