tracing(instrumentation): add http.route span attribute #10981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
feat/tracing-add-span-attribute
branch
from
9efe36a to
4e6c412
Compare
samugi
force-pushed
the
feat/tracing-add-span-attribute
branch
from
4e6c412 to
0e1e5fa
Compare
|
I'm linking the community issue so it will get closed automatically when the PR is merged. |
oowl
reviewed
Jun 27, 2023
add the http.route span attribute to the kong request span adapt existing tests to pass with the new attribute improve instrumentations tests, add checks for all spans and attributes
samugi
force-pushed
the
feat/tracing-add-span-attribute
branch
from
0e1e5fa to
20f6ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
http.routespan attribute to the kong request span, adapts existing tests to pass with the new attribute and improves instrumentation tests, by adding checks for all spans and attributes.Checklist
Full changelog
Issue reference
KAG-1719
#8125