refactor(plugins/ldap-auth): optimize the process of parsing and handling authentication headers #11780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabertobihwy
force-pushed
the
FTI-5329
branch
2 times, most recently
from
d04dedd to
385e731
Compare
sabertobihwy
changed the title
sabertobihwy
force-pushed
the
FTI-5329
branch
from
385e731 to
cad21ea
Compare
…ling authentication headers 1. use the `ngx.re.find` and `ngx.re.match` functions for more robust and efficient string matching operations. 2. adds error handling and logging for potential errors during authentication header parsing and credential decoding. 3. tweak the handling position for the case where `proxy_authorization_value` does not exist. Fix: [FTI-5329](https://konghq.atlassian.net/browse/FTI-5329) Signed-off-by: sabertobihwy <[email protected]>
sabertobihwy
force-pushed
the
FTI-5329
branch
from
cad21ea to
0e859f9
Compare
ms2008
reviewed
Oct 19, 2023
team-eng-enablement
added
the
author/community
ms2008
approved these changes
Oct 20, 2023
|
|
This comment was marked as duplicate.
This comment was marked as duplicate.
team-gateway-bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
…ling authentication headers (#11780) * refactor(plugins/ldap-auth): optimize the process of parsing and handling authentication headers 1. use the `ngx.re.find` and `ngx.re.match` functions for more robust and efficient string matching operations. 2. adds error handling and logging for potential errors during authentication header parsing and credential decoding. 3. tweak the handling position for the case where `proxy_authorization_value` does not exist. Fix: [FTI-5329](https://konghq.atlassian.net/browse/FTI-5329) Signed-off-by: sabertobihwy <[email protected]> * update by comments --------- Signed-off-by: sabertobihwy <[email protected]> Co-authored-by: tzssangglass <[email protected]> (cherry picked from commit 6ce55c4)
AndyZhang0707
pushed a commit
that referenced
this pull request
Oct 30, 2023
…ling authentication headers (#11780) (#11887) * refactor(plugins/ldap-auth): optimize the process of parsing and handling authentication headers 1. use the `ngx.re.find` and `ngx.re.match` functions for more robust and efficient string matching operations. 2. adds error handling and logging for potential errors during authentication header parsing and credential decoding. 3. tweak the handling position for the case where `proxy_authorization_value` does not exist. Fix: [FTI-5329](https://konghq.atlassian.net/browse/FTI-5329) Signed-off-by: sabertobihwy <[email protected]> * update by comments --------- Signed-off-by: sabertobihwy <[email protected]> Co-authored-by: tzssangglass <[email protected]> (cherry picked from commit 6ce55c4) Co-authored-by: Kurt Tu <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
ngx.re.findandngx.re.matchfunctions for more robust and efficient string matching operations.proxy_authorization_valuedoes not exist.Issue reference
Fix FTI-5329