Skip to content

Minor bug fix: Fix error message for retries #13605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Minor bug fix: Fix error message for retries #13605

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc44cb0
fix: Correct error message for retries variable
Sep 2, 2024
b70ad5f
tests: Update test expectations for retries variable
Sep 2, 2024
36b4d6e
Update changelog/unreleased/kong/fix-retries-error-message.yml
AD7six Sep 13, 2024
ac6b339
Merge branch 'master' into ad-retries-port
AD7six Sep 13, 2024
70b29bb
Merge branch 'master' into ad-retries-port
AD7six Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/fix-retries-error-message.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: "Fix error message for invalid retries variable"
type: bugfix
scope: Core
2 changes: 1 addition & 1 deletion kong/pdk/service.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ local function new()
error("retries must be an integer", 2)
end
if retries < 0 or retries > 32767 then
error("port must be an integer between 0 and 32767: given " .. retries, 2)
error("retries must be an integer between 0 and 32767: given " .. retries, 2)
end

local ctx = ngx.ctx
Expand Down
4 changes: 2 additions & 2 deletions t/01-pdk/09-service/04-set-retries.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ retries must be an integer
--- request
GET /t
--- response_body
port must be an integer between 0 and 32767: given -1
port must be an integer between 0 and 32767: given 32768
retries must be an integer between 0 and 32767: given -1
retries must be an integer between 0 and 32767: given 32768
--- no_error_log
[error]

Expand Down
Loading