fix(dao): plugin priority collision handling #8957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When plugin priorities collide we cannot guarantee a deterministic result from the sorting function. There are a couple of plugins that traditionally have colliding priorities like their EE counterparts. To ensure determinism this commit adds a collision detection that falls back to a plugin name based sorting. Also the function moved to the `kong.tools.utils` module to test it in isolation. Signed-off-by: Joshua Schmid <[email protected]>
bungle
approved these changes
Jun 15, 2022
jschmid1
added a commit
that referenced
this pull request
Aug 11, 2022
Signed-off-by: Joshua Schmid <[email protected]>
jschmid1
added a commit
that referenced
this pull request
Aug 12, 2022
Signed-off-by: Joshua Schmid <[email protected]>
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
(cherry picked from commit 651a4c6) Co-authored-by: lena-larionova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When plugin priorities collide we cannot guarantee a deterministic result from the sorting function. There are a couple of plugins that traditionally have colliding priorities like their EE counterparts. To ensure determinism this commit adds a collision detection that falls back to a plugin name based sorting. Also the function moved to the
kong.tools.utilsmodule to test it inisolation.
Signed-off-by: Joshua Schmid [email protected]
note that this is a backwards port from ee