fix(router) prefix match no longer normalize input #9389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
reviewed
Sep 7, 2022
|
Should we change the line 235 in |
chronolaw
reviewed
Sep 7, 2022
StarlightIbuki
force-pushed
the
fix/route_prefix_normalize
branch
from
93ee5e9 to
1fd17c8
Compare
StarlightIbuki
force-pushed
the
fix/route_prefix_normalize
branch
from
1fd17c8 to
fa46329
Compare
|
Could we add some special test cases for this change? for example, path likes |
chronolaw
approved these changes
Sep 7, 2022
added |
dndx
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
This LGTM, I will leave some time for others to review, but otherwise merge it tomorrow. Thanks @suika-kong @chronolaw for the quick turnaround!
bungle
approved these changes
Sep 7, 2022
|
Notice that this PR currently targets
|
tyler-ball
pushed a commit
that referenced
this pull request
Sep 7, 2022
tests(router): test for removed normalization
tyler-ball
pushed a commit
that referenced
this pull request
Sep 7, 2022
tests(router): test for removed normalization
dndx
pushed a commit
that referenced
this pull request
Oct 10, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant #9327 * transplant #9329 * transplant #9343 * transplant #9346 * transplant #9357 * transplant #9389 * transplant #9394 * transplant #9451 * transplant #9480
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
* rename `atc_compat.lua` to `compat.lua` * add a new file `expressions.lua` * move lots of logic into `atc.lua` * rename `get_atc` to `get_expression` * rename `route_priority` to `get_priority` * rename `atc_escape_str `to `escape_str` * remove function `paths_resort` * transplant Kong#9327 * transplant Kong#9329 * transplant Kong#9343 * transplant Kong#9346 * transplant Kong#9357 * transplant Kong#9389 * transplant Kong#9394 * transplant Kong#9451 * transplant Kong#9480
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
* feat(wasm): add support for wasmtime cache This adds support for Wasmtime's module caching. See also: * Kong/ngx_wasm_module#540 * https://github.com/Kong/ngx_wasm_module/blob/b19d405403ca6765c548e571010aea3af1accaea/docs/DIRECTIVES.md?plain=1#L136-L149 * https://docs.wasmtime.dev/cli-cache.html * tests(wasm): add start/restart test for wasmtime cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make it consistent with regex paths, so we do not normalize user input paths.
This PR also includes migration.
Remember to add downgrade support for this to EE.