Skip to content

Fix unexpected behaviour with km's inputs #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

fmeirinhos
Copy link
Collaborator

One would still need to fix the docstrings

@fmeirinhos fmeirinhos requested a review from LRydin January 18, 2024 11:52
@LRydin
Copy link
Owner

LRydin commented Dec 26, 2024

@fmeirinhos I think I will close this request. Unfortunately, I cannot see what the improvement is. This is much more explicit than the extant code ─ which isn't bad ─ but this is a very low-level code, so explicit means difficult to understand. I've tried to weave something out of the code, but it is difficult to see where the real improvement is.

@LRydin LRydin closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants