Skip to content
This repository was archived by the owner on Jun 16, 2022. It is now read-only.

fix spectron not running #3274

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix spectron not running #3274

merged 1 commit into from
Nov 5, 2020

Conversation

machard
Copy link
Contributor

@machard machard commented Nov 4, 2020

Spectron was not runnning because of electron-userland/spectron#174 (comment)

Type

bug fix

Context

https://ledgerhq.atlassian.net/browse/LL-3276

Parts of the app affected / Test plan

yarn spectron (needs yarn start running in an other terminal)

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

PR to merge fix-spectron-run e04cd7f -> develop

Diff output

Please download attached snapshots.zip, extract it in folder and update your PR with it

@nabil-brn nabil-brn self-requested a review November 4, 2020 14:47
@machard
Copy link
Contributor Author

machard commented Nov 4, 2020

Actually there is a problem when running on mac because of the screenshot size.
When running on a computer with a retina screen, the size of the screenshot is doubled.
I tried to resize capture on the fly to the size of the existing captures but it does not pass.
onboarding-1-get-started-diff

Copy link
Contributor

@nabil-brn nabil-brn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is a problem when running on mac because of the screenshot size.
When running on a computer with a retina screen, the size of the screenshot is doubled.
I tried to resize capture on the fly to the size of the existing captures but it does not pass.
onboarding-1-get-started-diff

UI tests are meant to run on CI inside docker containers, that's why the resolution is not the same, but it's actually a good idea to standardize those screenshots to be able to develop tests faster and make the debugging easier.

✓ QA-ed

Running on windows and macOS


0864416 (HEAD -> fix-spectron-run, machard/fix-spectron-run) fix spectron not running

@machard
Copy link
Contributor Author

machard commented Nov 4, 2020

I am looking at https://github.com/SeleniumHQ/docker-selenium#standalone and https://www.electronjs.org/docs/tutorial/using-selenium-and-webdriver

otherwise it would need to run the tests locally in a docker environment as well

edit: I think a possible idea is to run electron-chromedriver in docker and use webdriverOptions so that spectron points to it. https://github.com/Mendeley/docker-electron-chromedriver

@gre gre merged commit 94b5d28 into LedgerHQ:develop Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants