Skip to content

Use the best move eval instead of highest eval for temperature cutoff. #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

Mardak
Copy link
Contributor

@Mardak Mardak commented Feb 28, 2019

r?@mooskagh The current implementation didn't seem like it supports AlphaZero's by softmax sam- pling with a temperature of 10.0 among moves for which the value was no more than 1% away from the best move for the first 30 plies

In particular, a random single visit with high eval towards the end of limited node search could prevent selecting moves that got more visits.

@Mardak
Copy link
Contributor Author

Mardak commented Feb 28, 2019

Looking back at #568 I suppose it does say "best move" although I would think MCTS' "best" is most visited instead of highest eval. ??

Copy link
Member

@mooskagh mooskagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That if (edge.GetQ(fpu) > max_eval) is probably not needed.
Feel free to merge either variant though.

@mooskagh mooskagh merged commit f8519ae into LeelaChessZero:master Jun 10, 2019
@Mardak Mardak deleted the best-eval branch June 10, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants