Additional reporting details for selfplay to support T50+ #821
Conversation
| @@ -117,15 +119,18 @@ void SelfPlayGame::Play(int white_threads, int black_threads, bool training, | |||
| eval = (eval + 1) / 2; | |||
| if (eval < min_eval_[idx]) min_eval_[idx] = eval; | |||
| const int move_number = tree_[0]->GetPositionHistory().GetLength() / 2 + 1; | |||
| auto best_w = (best_eval.first + 1.0f - best_eval.second) / 2.0f; | |||
There was a problem hiding this comment.
Maybe add struct WDL { float win; float draw; float loss; } and use it instead? (for best_* and also for max_eval_).
I think even without constructor, curly braces initialization will work:
WDL best{(best_eval.first + 1.0f - best_eval.second) / 2.0f,
best_eval.second,
best_w - best_eval.first};There was a problem hiding this comment.
Feels a bit like overkill.
| @@ -171,6 +176,15 @@ std::vector<Move> SelfPlayGame::GetMoves() const { | |||
| } | |||
|
|
|||
| float SelfPlayGame::GetWorstEvalForWinnerOrDraw() const { | |||
| if (options_[0].uci_options->Get<bool>(kResignWDLStyleId.GetId())) { | |||
There was a problem hiding this comment.
Is it theoretically possible that player1 and player2 have different kResignWDLStyle values set? Then options_[0] won't work.
There was a problem hiding this comment.
Theoretically - yes. But not using the same resign style for both sides seems pretty silly.
There was a problem hiding this comment.
If it's <=3 lines of code change to add it, would be nice to support it to avoid future surprises.
There was a problem hiding this comment.
Actually its not. Its not the final position that matters for this function, its every single position so far. So its a bunch more work to support them having different values.
* Hack to report average nodes per move for monitoring training. * WDLstyle resign false positive reporting * Make this less WIP and more submittable. * Cast correctly. * Fix typo in last commit... * Add comment about unsupported combination.
…Zero#821) * Hack to report average nodes per move for monitoring training. * WDLstyle resign false positive reporting * Make this less WIP and more submittable. * Cast correctly. * Fix typo in last commit... * Add comment about unsupported combination.
No description provided.