Skip to content

Inner single quotes are not escaped #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LucasPickering opened this issue Feb 8, 2024 · 0 comments · Fixed by #71
Closed

Inner single quotes are not escaped #65

LucasPickering opened this issue Feb 8, 2024 · 0 comments · Fixed by #71
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@LucasPickering
Copy link
Owner

LucasPickering commented Feb 8, 2024 •
edited
Loading

With this config:

[applications.server.profiles.dev]
variables.BROKEN = "'; echo bobby tables '"

You get this:

> es set server dev
The following variables will be set:
BROKEN = '; echo bobby tables '
bobby tables

Oops! Nothing should be printed there. Offending core is here.
@LucasPickering LucasPickering added bug Something isn't working good first issue Good for newcomers labels Feb 8, 2024
LucasPickering added a commit that referenced this issue Feb 12, 2024
@LucasPickering
Escape single quotes in variable/values
b09d366 
Closes #65
@LucasPickering LucasPickering mentioned this issue Feb 12, 2024
Merged
LucasPickering added a commit that referenced this issue Feb 12, 2024
@LucasPickering
Escape single quotes in variable/values
36d8030 
Closes #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape single quotes in variable/values LucasPickering/env-select
1 participant
@LucasPickering