LTO,PTF functionality and tests added #127

aditeyashukla · 2025-02-11T15:45:58Z

Updated functions for

odperf
LTO
printBADA

Added P3T3 function for both narrow body (CFM56) and wide body (GE90) using curve fitting

Added tests for all 3 functions

Also, added aircraft_type in aircraft struct

codecov · 2025-02-11T15:55:39Z

Codecov Report

Attention: Patch coverage is 70.00000% with 150 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (181c5a0) to head (45f8c6b).

Files with missing lines	Patch %	Lines
src/mission/odperformance.jl	63.14%	129 Missing ⚠️
src/IO/output_LTO_perf.jl	86.66%	10 Missing ⚠️
src/IO/output_BADA.jl	86.88%	8 Missing ⚠️
src/IO/read_input.jl	83.33%	2 Missing ⚠️
src/misc/aircraft.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   79.04%   81.08%   +2.04%     
==========================================
  Files          84       80       -4     
  Lines       13650    13864     +214     
==========================================
+ Hits        10790    11242     +452     
+ Misses       2860     2622     -238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aditeyashukla · 2025-02-25T16:39:15Z

src/mission/LTO.jl

rename to generate_BADA()

src/misc/aircraft.jl

src/IO/read_input.jl

argonaut22 · 2025-02-25T23:41:11Z

To clarify my drowsy thoughts from earlier:

I think LTO.jl and printBADA.jl belong in IO/ as output_offdesign.jl: output_LTO_perf and output_BADA. Though there are calcs being done, they don't seem to affect the aircraft data and, thus, it's output
odperf does seem to affect the ac via tfcalc! and cdsum!. thus, makes sense in mission/. Does running odperf change the aircraft for subsequent evaluations of other missions? I'm not that familiar with this functionality
I still don't like aircraft_type as a top-level option since it's unused except for this one function. Would prefer a required parameter like odperf!(ac, aircraft_type("narrow body")). If we must have it, then please just use Strings. we evolved past the need for Int flags

term fix

…ents

…om png to svg

Co-authored-by: Prashanth <[email protected]>

back to default in PRD

fixed test error

Fix error in loads testing Fix unit tests - the inputs should not be dependent on the default sizing regression test. update outputs Update tests after conflict

argonaut22 · 2025-02-28T19:19:31Z

src/IO/read_input.jl

+    elseif lowercase(aircraft_type) == "regional aircraft"
+        return :regional
+    else
+        return :narrow


how about else @error(...)?

argonaut22

mostly best practices suggestions and continued distaste for aircraft_type

may i also recommend a description in the IO part of the docs?

argonaut22 · 2025-02-28T19:25:25Z

src/IO/output_LTO_perf.jl

+    return EI_NOx
+end  # function EINOx4
+
+function EINOx(ac::aircraft, ip::Int; sp_humidity = 0.00634, method="cubic")


This is the only place that uses aircraft_type. Would still vote against having it as a field and vote for having it as an input whenever odperf!() is called (which then passes to EINOx and co).

Suggested change

function EINOx(ac::aircraft, ip::Int; sp_humidity = 0.00634, method="cubic")

function EINOx(ac::aircraft, ip::Int, aircraft_type::Sym; sp_humidity = 0.00634, method="cubic")

the motivation is that "narrow-body"/"wide-body" is too big of a user-facing lever that does nothing anywhere else. it's unintuitive

perhaps a better var name is correlation_type, since that is the extent of its influence

argonaut22 · 2025-02-28T19:29:14Z

src/IO/output_LTO_perf.jl

+Assumes a default specific humidity of 0.00634 kg water/kg dry air per 
+ICAO Annex 16 Vol. II (part 2.1.4.1)
+"""
+function EINOx3(P3_kPa, T3_K, sp_humidity = 0.00634, ac_type = "1")


ac_type default is outdated

Also, should this even have a default? the likelihood of error is greater than the convenience

argonaut22 · 2025-02-28T19:29:52Z

src/IO/output_LTO_perf.jl

+Assumes a default specific humidity of 0.00634 kg water/kg dry air per 
+ICAO Annex 16 Vol. II (part 2.1.4.1)
+"""
+function EINOx4(P3_kPa, T3_K, sp_humidity = 0.00634, ac_type = "1")


(see above)

argonaut22 · 2025-02-28T19:42:43Z

src/mission/odperformance.jl

+    println(@sprintf("%12s %12s %12s %12s %12s %12s %12s %12s %12s %12s %12s %12s %12s %12s", 
+    "FL", "TAS", "CAS", "Mach", "Fn", "L/D", "Tt4max", "Tmetmax", "FFmax", "Tt4cruise", "Tmetcruise", "FFcruise", "CL", "CLh"))
+    # integrate trajectory over climb
+    for   i = 1:N


labelled indices are nice

Suggested change

for i = 1:N

for iFL = 1:N

argonaut22 · 2025-02-28T19:44:43Z

src/mission/odperformance.jl

+end
+
+
+## FOR 77W__


what in tarnation is 77W

LTO,PTF functionality and tests added

9b6f208

aditeyashukla requested a review from askprash February 11, 2025 15:46

aditeyashukla and others added 3 commits February 11, 2025 11:10

adding test files

8ea629a

Merge branch 'main' into LTO_new

59b7320

Merge branch 'main' into LTO_new

4bf43dd

aditeyashukla commented Feb 25, 2025

View reviewed changes

src/mission/LTO.jl Outdated

Copy link

Contributor Author

aditeyashukla Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to generate_BADA()

aditeyashukla commented Feb 25, 2025

View reviewed changes

src/misc/aircraft.jl Outdated Show resolved Hide resolved

aditeyashukla commented Feb 25, 2025

View reviewed changes

src/IO/read_input.jl Outdated Show resolved Hide resolved

ngomezve and others added 20 commits February 27, 2025 11:43

inverted engine initialization logic

7fc2f6e

avoiding engine initialization in mission

b38af86

created file with turbomachinery maps

68272c9

added maps with varying polytropic eff

33ac5cd

fixed tests

1e80d5b

term fix

updated engine tests after changes in maps

54989e7

Updated turbomachinery documentation to include E3 vs Drela plots

544e275

updates map comment

7d6f62f

updated off design tests

da56cdd

adding link to E3 nasa report alongside journal paper to maps.jl comm…

73e7705

…ents

removed extraneous gridded maps and converted map data vs fit plot fr…

ae19503

…om png to svg

Remove Documenter.jl from Project.toml

bbe019b

Co-authored-by: Prashanth <[email protected]>

Remove Documenter.jl from compatibility in Project.toml

4c85251

Co-authored-by: Prashanth <[email protected]>

moved tank params from wsize to tanksize

686b689

changed outputs of size inner tank

bab973e

removed boiloff references + fixed tests

2aa4b4b

simplified update_fuse inputs and layout

63aa723

revived PR diagram for ac with only one mission

c816ce3

back to default in PRD

fixes for double decker + storing off-design SL temp

82d9f55

fixed test error

set default mission for tanksize and update_fuse

af372aa

askprash and others added 22 commits February 27, 2025 11:44

Cleanup surfcd2

6311b75

make wing type stable

185b9fa

clean up that hack

069e63e

clean up cdsum

d320301

remove unnecessary float conversions

f31d290

Update index to make all indices const.

64dee82

Add some docstrings to airfun

5cdb443

add some explanatory text

254c393

factor out 2bref/(0.5Sref)

497b376

Remove unnecessary float conversions and add minor comments

bee06cb

Some comments + typo fix

4d00136

fix index

9b1483b

comment in cdsum

0e5c460

Cleanup plotting and airfun

213af07

add theory docs

b21c124

minor updates to surfcd2

8d10b58

Get rid of the last bit of allocations

ab129ce

BUG FIX in spline... urgh.

4235416

Update all tests and outputs related to testing

001733c

Fix error in loads testing Fix unit tests - the inputs should not be dependent on the default sizing regression test. update outputs Update tests after conflict

Update src/aero/trefftz.jl

b1ff2a0

Update src/aero/trefftz.jl

eb94d23

made requested changes, updated tests

78fe3c7

aditeyashukla requested a review from argonaut22 February 27, 2025 16:58

aditeyashukla added 3 commits February 27, 2025 12:00

Merge branch 'main' into LTO_new

dd870e6

Merge branch 'main' into LTO_new

90d5f0d

tests updated (never use github website to fix merge conflicts...)

45f8c6b

argonaut22 reviewed Feb 28, 2025

View reviewed changes

askprash force-pushed the main branch from 5ce43eb to 181c5a0 Compare March 2, 2025 22:32

aditeyashukla force-pushed the LTO_new branch from 65d9806 to 45f8c6b Compare March 3, 2025 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

LTO,PTF functionality and tests added #127

LTO,PTF functionality and tests added #127

Uh oh!

aditeyashukla commented Feb 11, 2025

Uh oh!

codecov bot commented Feb 11, 2025 •

edited

Loading

Uh oh!

aditeyashukla Feb 25, 2025

Uh oh!

Uh oh!

Uh oh!

argonaut22 commented Feb 25, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 left a comment

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

argonaut22 Feb 28, 2025

Uh oh!

Uh oh!

	function EINOx(ac::aircraft, ip::Int; sp_humidity = 0.00634, method="cubic")
	function EINOx(ac::aircraft, ip::Int, aircraft_type::Sym; sp_humidity = 0.00634, method="cubic")

LTO,PTF functionality and tests added #127

Are you sure you want to change the base?

LTO,PTF functionality and tests added #127

Uh oh!

Conversation

aditeyashukla commented Feb 11, 2025

Uh oh!

codecov bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

argonaut22 commented Feb 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

argonaut22 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Feb 11, 2025 •

edited

Loading