Skip to content

TextSeparator = ", " for concatenating errors #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelcsikos opened this issue May 6, 2022 · 2 comments · Fixed by #3942
Closed

TextSeparator = ", " for concatenating errors #2925

michaelcsikos opened this issue May 6, 2022 · 2 comments · Fixed by #3942
Assignees
@Freelancingonupwork
Labels
kind/enhancement

Comments

@michaelcsikos
Copy link

The standard validation error messages such as [Required] are proper sentences ending with a . and I think this is good practice. Csla.Blazor.PropertyInfo assumes error messages won't end with a . using ", " to concatenate errors, so you end up with:

image

Should TextSeparator = " " or perhaps be a public static string TextSeparator { get; set; } instead?
@rockfordlhotka
Copy link
Member

It seems like something someone could set, and perhaps the default should be " ".

@Freelancingonupwork Freelancingonupwork mentioned this issue May 15, 2024
Merged
Freelancingonupwork added a commit to Freelancingonupwork/csla that referenced this issue May 15, 2024
@Freelancingonupwork
Merge branch 'main' into MarimerLLC#2925-TextSeparator-for-concatenat…
f3ccf2a 
…ing-errors/main
@rockfordlhotka rockfordlhotka moved this to In Progress in CSLA Version 9.0.0 May 15, 2024
rockfordlhotka added a commit to Freelancingonupwork/csla that referenced this issue May 17, 2024
@rockfordlhotka
Merge branch 'main' into MarimerLLC#2925-TextSeparator-for-concatenat…
9e7b131 
…ing-errors/main
rockfordlhotka added a commit to Freelancingonupwork/csla that referenced this issue May 20, 2024
@rockfordlhotka
Merge branch 'main' into MarimerLLC#2925-TextSeparator-for-concatenat…
e9870fb 
…ing-errors/main
rockfordlhotka added a commit that referenced this issue May 20, 2024
@Freelancingonupwork @StefanOssendorf @rockfordlhotka
#2925 text separator for concatenating errors/main (#3942)
9df9274 
* Add DisplayIndex Property to Business Rules

* Test

* Update

* Text separator for concatenating errors

* Chnages

---------

Co-authored-by: Stefan Ossendorf <[email protected]>
Co-authored-by: Mayur Kasidariya <[email protected]>
Co-authored-by: Rockford Lhotka <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in CSLA Version 9.0.0 May 20, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Freelancingonupwork Freelancingonupwork

Labels
kind/enhancement
Projects
No open projects
CSLA Version 9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2925 text separator for concatenating errors/main Freelancingonupwork/csla
3 participants
@rockfordlhotka @michaelcsikos @Freelancingonupwork