Skip to content

compute: sink dataflow errors to persist #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

compute: sink dataflow errors to persist #13437

merged 1 commit into from
Jul 4, 2022

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Jul 4, 2022

This change enables propagation of query errors (like division by zero) through recorded views.

Motivation

  • This PR adds a known-desirable feature.

Part of MaterializeInc/database-issues#3692.

Testing

  • This PR has adequate test coverage / QA involvement has been duly considered.

Release notes

This PR includes the following user-facing behavior changes:

  • Add error propagation through recorded views.

@teskje teskje marked this pull request as ready for review July 4, 2022 14:04
@teskje teskje requested a review from antiguru July 4, 2022 14:04
@teskje
Copy link
Contributor Author

teskje commented Jul 4, 2022

cc @philip-stoev: This fixes item no. 8 from #13346.

antiguru
antiguru approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine!

@teskje
compute: sink dataflow errors to persist
22d3f28 
This change enables propagation of query errors (like division by zero)
through recorded views.
@teskje teskje force-pushed the recorded-view-propagate-errors branch from 9af7d87 to 22d3f28 Compare July 4, 2022 14:28
@teskje teskje enabled auto-merge (rebase) July 4, 2022 14:28
philip-stoev
philip-stoev approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for testing retractions as well!

@teskje teskje merged commit bf6a30b into MaterializeInc:main Jul 4, 2022
@teskje teskje deleted the recorded-view-propagate-errors branch July 4, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiguru antiguru antiguru approved these changes

@philip-stoev philip-stoev philip-stoev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teskje @antiguru @philip-stoev