Skip to content

adapter: avoid more tracing ref panics in explain codepaths #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Nov 10, 2023

I cant find where these .await points were added (these were refactored and move multiple times recently, but any use of tokio sync objects can cause this issue

@aljoscha @aalexandrov do you know if these calls to sequence_peek_timestamp were originally added long enough ago that its in this weeks release? if so this needs to be backported

Motivation

  • This PR fixes a recognized bug.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@guswynn guswynn requested a review from a team as a code owner November 10, 2023 00:44
@maddyblue
Copy link
Contributor

These were made async in #22091 from October 2.

@guswynn
Copy link
Contributor Author

guswynn commented Nov 10, 2023

@mjibson sounds good, we can just fix forward then!

@guswynn guswynn enabled auto-merge (rebase) November 10, 2023 17:14
Copy link
Contributor

@aljoscha aljoscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this does indeed fixed the failures I saw in nightly runs of my oracle PR!

@guswynn guswynn merged commit c29b491 into MaterializeInc:main Nov 10, 2023
@guswynn guswynn deleted the more-tracing-panics branch November 10, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants