Skip to content

[Backport 3.6] Fix v3.6 issues 9186 and 9188 bp #9451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

minosgalanakis
Copy link
Contributor

@minosgalanakis minosgalanakis commented Aug 6, 2024

Description

This is a backport of #9189

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

misch7 and others added 20 commits August 6, 2024 11:26
… set (fixes Mbed-TLS#9188)

Avoid compiler warning about size comparison (like in commit 7910cdd):

Clang builds fail, warning about comparing uint8_t to a size that may be >255.

Signed-off-by: Michael Schuster <[email protected]>
…build_no_ssl_cli in all.sh

Signed-off-by: Michael Schuster <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
…programs

Reduce code duplication and fix missing-prototype error for print_buf

Signed-off-by: Michael Schuster <[email protected]>
…OneInput prototype to common.h

Signed-off-by: Michael Schuster <[email protected]>
Signed-off-by: Michael Schuster <[email protected]>
…sa_crypto.function

This function is not referenced anywhere in the whole codebase.

Signed-off-by: Michael Schuster <[email protected]>
…he top-level CMakeLists.txt for GCC & Clang

Signed-off-by: Michael Schuster <[email protected]>
In that case mbedtls_psa_platform_get_builtin_key is already declared.

Signed-off-by: Michael Schuster <[email protected]>
Fix unused-function errors.

Signed-off-by: Michael Schuster <[email protected]>
…ix missing-prototype error

Signed-off-by: Michael Schuster <[email protected]>
@minosgalanakis minosgalanakis changed the base branch from development to mbedtls-3.6 August 6, 2024 11:29
@gilles-peskine-arm gilles-peskine-arm self-requested a review August 6, 2024 11:35
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon component-tls component-platform Portability layer and build scripts size-s Estimated task size: small (~2d) labels Aug 6, 2024
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a backport of #9189

@eleuzi01 eleuzi01 self-requested a review August 7, 2024 09:03
eleuzi01
eleuzi01 previously approved these changes Aug 7, 2024
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Aug 7, 2024
@mpg mpg added priority-very-high Highest priority - prioritise this over other review work and removed priority-high High priority - will be reviewed soon labels Aug 9, 2024
@gilles-peskine-arm gilles-peskine-arm dismissed stale reviews from eleuzi01 and themself via 3001e27 August 10, 2024 05:03
@gilles-peskine-arm gilles-peskine-arm force-pushed the fix-v3.6-issues-9186-and-9188-bp branch from c695fc5 to 3001e27 Compare August 10, 2024 05:03
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after submodule update

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Aug 10, 2024
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Aug 12, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Aug 12, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 7f9470a Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports component-platform Portability layer and build scripts component-tls priority-very-high Highest priority - prioritise this over other review work size-s Estimated task size: small (~2d)
Projects
Development

Successfully merging this pull request may close these issues.

5 participants