Finalize split preparation-2 #9828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronald-cron-arm
added
enhancement
needs-ci
minosgalanakis
previously approved these changes
Dec 9, 2024
| @@ -2167,6 +2158,8 @@ component_test_ccm_aes_sha256 () { | |||
|
|
|||
| # Setting a blank config disables everyhing in the library side. | |||
| echo '#define MBEDTLS_CONFIG_H ' >"$CONFIG_H" | |||
| cp configs/crypto-config-ccm-aes-sha256.h "$CRYPTO_CONFIG_H" | |||
There was a problem hiding this comment.
Thanks. I've compared the outcomes.csv from before and after #9567 and it was quite clear there was an issue with test_ccm_aes_sha256.
gabor-mezei-arm
previously approved these changes
Dec 9, 2024
ronald-cron-arm
dismissed stale reviews from gabor-mezei-arm and minosgalanakis
via
44bb9a5
ronald-cron-arm
force-pushed
the
finalize-split-preparation-2
branch
2 times, most recently
from
4bb70cf to
1109a09
Compare
5 tasks
Signed-off-by: Ronald Cron <[email protected]>
Just to ease the eventual migration of check-generated-files.sh to the framework. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Move test_keys.h to tests/include/test instead of tests/src as it is used outside of tests/src namely by test_suite_pk. Signed-off-by: Ronald Cron <[email protected]>
This reverts commit 939ce9d. Build mbedtls_test library of objects to link with TLS and x509 test suites and programs with mbedtls framework not TF-PSA-Crypto one (when it will be there). Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Move the docuumentation files that after the split will fit better in TF-PSA-Crypto than Mbed TLS. No comment update. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Add missing dependency of visualc file generation on programs and tests generated files. Signed-off-by: Ronald Cron <[email protected]>
ronald-cron-arm
force-pushed
the
finalize-split-preparation-2
branch
from
1109a09 to
8a09a41
Compare
ronald-cron-arm
added
needs-review
|
@minosgalanakis @gabor-mezei-arm CI is green now, please have another look, thanks. |
Signed-off-by: Ronald Cron <[email protected]>
ronald-cron-arm
dismissed stale reviews from minosgalanakis and gabor-mezei-arm
via
2d40a24
Merged
via the queue into
Mbed-TLS:development
with commit Dec 11, 2024
f3720c7
4 of 6 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progresses #9624
PR checklist