feat: create common code editor dialog #86
+246
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also involves a refactor. But primarily it is designed so that the dialogs which contain code editors can share styles and features across them. The layer can also inform the header of the code editor, like "Annotation shader editor"
seankmartin
commented
Jun 6, 2025
seankmartin
commented
Jun 6, 2025
|
The gutter overlaps |
with the changes, the top row is now shared logic across layers, so a specific class is not needed as the style can be controlled from one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also involves a refactor. But primarily it is designed so that the dialogs which contain code editors can share styles and features across them.
The layer can also inform the header of the code editor, like "Annotation shader editor"