Skip to content

Support for rpi-imager: Selection of DietPi #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

StephanStS
Copy link
Collaborator

@StephanStS StephanStS commented Mar 8, 2025

Needed for rpi-imager integration:

  • DietPi logo
  • .json file (testwise extended, needs to be reduced later). File can be renamed to dietpi_list.json

To request DietPi to be integrated into rpi-imager OS list, these files need to be supplied.

Local usage (with extended .json file): rpi-imager --repo custom_os_list.json

@StephanStS StephanStS added the META Everything that is not code related, e.g. GitHub, Wiki, website, community label Mar 8, 2025
@StephanStS StephanStS added this to the v9.12 milestone Mar 8, 2025
@StephanStS StephanStS requested a review from MichaIng March 8, 2025 15:29
@StephanStS StephanStS self-assigned this Mar 8, 2025
@StephanStS StephanStS marked this pull request as draft March 8, 2025 16:03
@StephanStS StephanStS changed the title SVG and 40px PNG DietPi logo Support for rpi-imager: Selection of DietPi Mar 8, 2025
@MichaIng
Copy link
Owner

This is something to implement into rpi-imager itself, instead of in DietPi, isn't it? Or what would be the reason someone adds a custom OS via custom JSON and load it via console with rpi-imager, instead of just downloading and flashing the DietPi image directly?

Did you find the JSON in the source code? I could find the docs only 🤔: https://github.com/raspberrypi/rpi-imager/blob/qml/doc/json-schema/os-list-schema.json
Is it entirely hosted on a server outside of the source code repository? You mentioned there is a web mask to request adding a new OS to the RPi imager. Can you post the link?

@StephanStS
Copy link
Collaborator Author

This is something to implement into rpi-imager itself, instead of in DietPi, isn't it? Or what would be the reason someone adds a custom OS via custom JSON and load it via console with rpi-imager, instead of just downloading and flashing the DietPi image directly?

Did you find the JSON in the source code? I could find the docs only 🤔: https://github.com/raspberrypi/rpi-imager/blob/qml/doc/json-schema/os-list-schema.json Is it entirely hosted on a server outside of the source code repository? You mentioned there is a web mask to request adding a new OS to the RPi imager. Can you post the link?

It's there: https://forms.gle/cbsU27aLLVaxUXbw8
See also: raspberrypi/rpi-imager#545

I think there are these options:

  • Add RPI images via form (given above) to rpi-imager
  • Generate an own .json which also supports other hardware variants we support and somehow spread it via DietPi
  • Do both

@MichaIng MichaIng modified the milestones: v9.12, v9.13 Apr 18, 2025
@MichaIng MichaIng linked an issue Apr 19, 2025 that may be closed by this pull request
@MichaIng MichaIng force-pushed the dev-StS_DietPi-Logo-svg branch from 4b0ddda to 4e4316e Compare April 24, 2025 18:57
@MichaIng MichaIng marked this pull request as ready for review April 24, 2025 19:16
@MichaIng MichaIng force-pushed the dev-StS_DietPi-Logo-svg branch from 4f59c41 to c93ba37 Compare April 25, 2025 14:21
@MichaIng
Copy link
Owner

MichaIng commented Apr 25, 2025

I filled the form. @lurch if I may:

image

  • DietPi ships with a default password.
  • It can be changed during early boot stage (before network and login prompts) via dietpi.txt file on the FAT/boot partition.
  • With the same config file, an SSH pubkey can be provided, and SSH password login for root or all users can be disabled, which is as well applied during early boot stage, before network and SSH server are started.
  • On first login, users are further presented a dialogue to change the password.
  • Right now, No/ESC can be selected to skip changing the default password. But we could make it mandatory.

@lurch
Copy link

lurch commented Apr 25, 2025

@lurch if I may:

Again, these are all questions for @tdewey-rpi rather then myself. I believe the problem with leaving a default password enabled is that it leaves your OS vulnerable to botnet attacks.

@tdewey-rpi
Copy link

@lurch is again correct - I'm the effective curator of the OS list.

Right now, No/ESC can be selected to skip changing the default password. But we could make it mandatory.

I'm not entirely comfortable with that posture. In such a case, users of Raspberry Pi Imager could be inadvertently creating botnet nodes by selecting DietPi and making choices that wouldn't necessarily be obviously poor. If you are prepared to accommodate the change mandating the user set an authentication credential of their choice, I would be minded to accept the DietPi posture on this question.

@MichaIng
Copy link
Owner

Okay, I'll make the password change mandatory on first login, with next DietPi release, planned for Mai 17th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
META Everything that is not code related, e.g. GitHub, Wiki, website, community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dietpi to community pi-imager
4 participants