Skip to content

Do not compute hash for logging in RPC #16569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Feb 4, 2025

Do not compute scan state hash to perform a debug log in an RPC.

Use an available staged ledger hash value.

Explain how you tested your changes:

  • No specific tests we just move debug logging from one place to another

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

Do not compute scan state hash to perform a debug log in an RPC.

Use an available staged ledger hash value.
@georgeee georgeee requested a review from a team as a code owner February 4, 2025 22:38
Base automatically changed from georgeee/no-staged-ledger-hash-in-rpc to compatible February 5, 2025 18:37
@georgeee
Copy link
Member Author

georgeee commented Feb 5, 2025

!ci-build-me

@georgeee georgeee merged commit 7f253cf into compatible Feb 5, 2025
46 checks passed
@georgeee georgeee deleted the georgeee/no-staged-ledger-hash-in-rpc-no-debug-log branch February 5, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants