Skip to content

Proof-systems: bump up to latest master #16782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Mar 26, 2025

Bumping up proof-systems to current last master commit: e8de9488f4c7428d989eebe32c02d23b6f7d9f1d
Bumping up proof-systems to o1-labs/proof-systems@86f0695, which is not master yet, but reverts a commit that introduces a bug.

Running cargo vendor kimchi-stubs-vendor does not require any change.

In a future PR, wasm-bindgen will be updated in proof-systems and in this repository.

@dannywillems dannywillems requested a review from a team as a code owner March 26, 2025 19:07
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

Converting to draft, there is a breaking change in proof-systems.

@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems requested a review from volhovm March 26, 2025 21:28
@dannywillems
Copy link
Member Author

dannywillems commented Mar 26, 2025

Before c89e229, this error was happening.

File "src/lib/pickles/test/chunked_circuits/dune", line 2, characters 8-15:
2 |  (names chunks2 chunks4 chunks8)
            ^^^^^^^
Uncaught exception:
  (monitor.ml.Error
   (Failure "Prover(\"rest of division by vanishing polynomial\")")
   ("Raised at Base__Result.ok_exn in file \"src/result.ml\", line 201, characters 17-26"
    "Called from Async_kernel__Deferred1.M.map.(fun) in file \"src/deferred1.ml\", line 17, characters 40-45"
    "Called from Async_kernel__Job_queue.run_job in file \"src/job_queue.ml\" (inlined), line 128, characters 2-5"
    "Called from Async_kernel__Job_queue.run_jobs in file \"src/job_queue.ml\", line 169, characters 6-47"
    "Caught by monitor block_on_async"))
Raised at Base__Result.ok_exn in file "src/result.ml" (inlined), line 201, characters 17-26
Called from Async_unix__Thread_safe.block_on_async_exn in file "src/thread_safe.ml", line 132, characters 29-63
Called from Async_unix__Thread_safe.block_on_async_exn in file "src/thread_safe.ml" (inlined), line 181, characters 27-54
Called from Dune__exe__Chunks2.test.test_prove in file "src/lib/pickles/test/chunked_circuits/chunks2.ml", line 116, characters 6-63
Called from Dune__exe__Chunks2 in file "src/lib/pickles/test/chunked_circuits/chunks2.ml", line 132, characters 2-9
File "src/lib/pickles/test/chunked_circuits/dune", line 2, characters 16-23:
2 |  (names chunks2 chunks4 chunks8)
                    ^^^^^^^
compile time: 0.100414s
Uncaught exception:
  (monitor.ml.Error
   (Failure "Prover(\"rest of division by vanishing polynomial\")")
   ("Raised at Base__Result.ok_exn in file \"src/result.ml\", line 201, characters 17-26"
    "Called from Async_kernel__Deferred1.M.map.(fun) in file \"src/deferred1.ml\", line 17, characters 40-45"
    "Called from Async_kernel__Job_queue.run_job in file \"src/job_queue.ml\" (inlined), line 128, characters 2-5"
    "Called from Async_kernel__Job_queue.run_jobs in file \"src/job_queue.ml\", line 169, characters 6-47"
    "Caught by monitor block_on_async"))
Raised at Base__Result.ok_exn in file "src/result.ml" (inlined), line 201, characters 17-26
Called from Async_unix__Thread_safe.block_on_async_exn in file "src/thread_safe.ml", line 132, characters 29-63
Called from Async_unix__Thread_safe.block_on_async_exn in file "src/thread_safe.ml" (inlined), line 181, characters 27-54
Called from Dune__exe__Chunks4.test.test_prove in file "src/lib/pickles/test/chunked_circuits/chunks4.ml", line 66, characters 6-63
Called from Dune__exe__Chunks4 in file "src/lib/pickles/test/chunked_circuits/chunks4.ml", line 77, characters 2-9
File "src/lib/pickles/test/chunked_circuits/dune", line 2, characters 24-31:
2 |  (names chunks2 chunks4 chunks8)
                            ^^^^^^^
compile time: 0.100318s
Uncaught exception:
  (monitor.ml.Error
   (Failure "Prover(\"rest of division by vanishing polynomial\")")
   ("Raised at Base__Result.ok_exn in file \"src/result.ml\", line 201, characters 17-26"
    "Called from Async_kernel__Deferred1.M.map.(fun) in file \"src/deferred1.ml\", line 17, characters 40-45"
    "Called from Async_kernel__Job_queue.run_job in file \"src/job_queue.ml\" (inlined), line 128, characters 2-5"
    "Called from Async_kernel__Job_queue.run_jobs in file \"src/job_queue.ml\", line 169, characters 6-47"
    "Caught by monitor block_on_async"))
Raised at Base__Result.ok_exn in file "src/result.ml" (inlined), line 201, characters 17-26
Called from Async_unix__Thread_safe.block_on_async_exn in file "src/thread_safe.ml", line 132, characters 29-63
Called from Async_unix__Thread_safe.block_on_async_exn in file "src/thread_safe.ml" (inlined), line 181, characters 27-54
Called from Dune__exe__Chunks8.test.test_prove in file "src/lib/pickles/test/chunked_circuits/chunks8.ml", line 66, characters 6-63
Called from Dune__exe__Chunks8 in file "src/lib/pickles/test/chunked_circuits/chunks8.ml", line 77, characters 2-9

After bisecting the commits in proof-systems, I ended up with the commit o1-labs/proof-systems@3647beb being the first to make the tests fail.
I would prefer to revert this commit and re-introduce the changes (with a fix) later.

@dannywillems dannywillems marked this pull request as ready for review March 26, 2025 21:51
@dannywillems dannywillems changed the base branch from dw/plonk-wasm-fix-warnings to compatible March 27, 2025 14:44
@dannywillems
Copy link
Member Author

dannywillems commented Mar 27, 2025

Not merging until having an o1js PR updating to this version. I am on it.

@dannywillems
Copy link
Member Author

Ci of o1js counterpart is good, except minor jobs not impacted by these changes. Merging this one to move on the others.

@dannywillems dannywillems merged commit f5e388e into compatible Mar 27, 2025
44 checks passed
@volhovm volhovm deleted the dw/bumping-up-proof-systems-deps branch March 27, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants