Skip to content

Change json format in mina advanced verify-commands #16869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

Change json format in mina advanced verify-commands #16869

merged 5 commits into from
Apr 14, 2025

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Apr 7, 2025 •
edited
Loading

Update mina advanced verify-commands

  • Use JSON format that assumes hashes omitted from description of
    commands.
  • Provide support for the old format via the --legacy flag.
  • Introduce a minor change in error output format

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner April 7, 2025 08:33
georgeee added 3 commits April 7, 2025 08:36
@georgeee
Update 'mina advanced verify-commands'
f0ca673 
Use JSON format that assumes hashes omitted from description of
commands.

Provide support for the old format via the `--legacy` flag.
@georgeee
Update Verify_proof daemon RPC
2f24439 
Accept user command in stable format
@georgeee
Add changelog
a870a51
@georgeee georgeee force-pushed the georgeee/change-json-format-in-advanced-very-commands branch from 67509ca to a870a51 Compare April 7, 2025 08:37
@georgeee
Copy link
Member Author

georgeee commented Apr 7, 2025

!ci-build-me

mrmr1993
mrmr1993 reviewed Apr 14, 2025
View reviewed changes
changes/16869.md Outdated
@@ -0,0 +1,15 @@
# PR #16869 Change json format in `mina advanced verify-commands`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rework this to be a one-line summary that we can include in the release notes?

@georgeee
Copy link
Member Author

!ci-build-me

@georgeee georgeee merged commit 62da5c1 into compatible Apr 14, 2025
50 checks passed
@georgeee georgeee deleted the georgeee/change-json-format-in-advanced-very-commands branch April 14, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 left review comments

@dkijania dkijania dkijania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgeee @mrmr1993 @dkijania