Replace module hooking with tree-defined targeting #1527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though existing code does not error, we should never ever hook/wrap a module that will never particpates in quantization. This doesn't make any sense. The fix is much more complicated and likely require for 2-3 PRs to refractor.
Currently add optional pin-point module targeting via
tree
ofbase.layers_modules_tree
. This will play nicely into more generic multi-modal support as mm models embeds up to 3 separate models essentially into 1. The existing static-non-tree based config will be harder to support.Tree syntax