[TASK] Deconflate getAllValues() parameters
#1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$element` parameter was overloaded with a dual purpose. A second separate parameter has been added for rule filtering, which is not actually mutually exclusive with CSS subtree selection. Since `getAllValues()` is part of the public API, the method now supports being called with the old or new signatures, with the old signature being deprecated. Once the deprecation has been included in the 8.x release branch, the messiness of supporting the previous API can be removed. Part of #994. Also relates to #1230.
oliverklee
approved these changes
Apr 11, 2025
JakeQZ
added a commit
that referenced
this pull request
Apr 11, 2025
JakeQZ
added a commit
that referenced
this pull request
Apr 11, 2025
oliverklee
pushed a commit
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$elementparameter was overloaded with a dual purpose.A second separate parameter has been added for rule filtering, which is not actually mutually exclusive with CSS subtree selection.
Since
getAllValues()is part of the public API, the method now supports being called with the old or new signatures, with the old signature being deprecated.Once the deprecation has been included in the 8.x release branch, the messiness of supporting the previous API can be removed.
Part of #994. Also relates to #1230.