Fix various typings #1132
Open
Fix various typings #1132
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
May 20, 2025
| @@ -22,6 +22,7 @@ export interface TilesRendererEventMap { | |||
| export class TilesRenderer<TEventMap extends TilesRendererEventMap = TilesRendererEventMap> extends TilesRendererBase implements EventDispatcher<TEventMap> { | |||
|
|
|||
| ellipsoid: Ellipsoid; | |||
| cameras: Camera[]; | |||
There was a problem hiding this comment.
"cameras" isn't intended to be part of the public API and as such it's not documented. Do you need this field? Can you explain how you're using it?
edit
I just reread your main comment:
My use case was to compute the camera elevation in the intersectsTile function of a custom BaseRegion from LoadRegionPlugin
Can you explain this a bit more? You're reusing the cameras in a custom region plugin? What exactly is the intent?
gkjohnson
reviewed
May 20, 2025
Comment on lines
+40
to
+42
| calculateHorizonDistance( latitude: number, elevation: number ): number; | ||
| calculateEffectiveRadius( latitude: number ): number; | ||
|
|
There was a problem hiding this comment.
These functions were added for GlobeControls and I don't want to consider them public at the moment. If they're going to be made public I'd like to consider some more descriptive names for the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure exactly what is public API, but I think at least the typings for Ellipsoid were just missing.
For the
camerasofTilesRenderer, I am not sure if this is supposed to be exposed. My use case was to compute the camera elevation in theintersectsTilefunction of a customBaseRegionfromLoadRegionPlugin. Let me know if you see a better way to do it.