Skip to content

Phonetics Editing with warning for deleting phonetics #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nole2701
Copy link
Collaborator

For phonetics editing:

  • There is no phonetics before editing and there is no phonetics after editing -> do nothing
  • There is no phonetics before editing and there is phonetics after editing -> save the new phonetics
  • There is phonetics before editing and there is no phonetics after editing -> ask user if they mean to delete phonetics
  • There is phonetics before editing and there is phonetics after editing -> if updated then save new, otherwise do nothing

pre-commit is commented out due to an issue with index.ts not updating after making a change to types in form.rs.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for dailp ready!

Name Link
🔨 Latest commit 963031d
🔍 Latest deploy log https://app.netlify.com/sites/dailp/deploys/68152c09510c92000868aad9
😎 Deploy Preview https://deploy-preview-444--dailp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GracefulLemming

This comment was marked as outdated.

Copy link
Contributor

@GracefulLemming GracefulLemming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving, but we probably want to replace the checkmark and its associated providers with something harder to miss soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants