Add helper script for kuberay rbac #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
terrykong
previously approved these changes
Jun 5, 2025
Signed-off-by: Hemil Desai <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| if result.returncode == 0 and result.stdout.strip(): | ||
| return result.stdout.strip() | ||
| except Exception: |
Check notice
Code scanning / CodeQL
Empty except Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the issue, the except Exception: block should log the exception using the existing print_error function. This ensures that any errors encountered during the execution of the subprocess.run command are visible to the user, aiding in debugging and transparency. The fallback behavior (return "default") can remain unchanged, as it provides a reasonable default in case of failure.
Steps to implement the fix:
- Modify the
except Exception:block to log the exception usingprint_error. - Include the exception message in the log for better debugging.
- Ensure the fallback behavior (
return "default") remains intact.
Suggested changeset
1
nemo_run/tools/kuberay_rbac.py
| @@ -62,4 +62,4 @@ | ||
| return result.stdout.strip() | ||
| except Exception: | ||
| pass | ||
| except Exception as e: | ||
| print_error(f"Failed to retrieve default namespace: {e}") | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
terrykong
previously approved these changes
Jun 5, 2025
Signed-off-by: Hemil Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run using
kuberay-rbacafter installing nemo-run.Start with
kuberay-rbac --help