Skip to content

Move old ImageDecoder to legacy module and make the nvImageCodec based ImageDecoder the default #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 9, 2024

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Apr 25, 2024

Category:

Other Replaces default ImageDecoders with the nvImageCodec based implementations.

Description:

  • Replaces default ImageDecoders with the nvImageCodec based implementations.
  • Move former default decoders to a legacy module

Additional information:

Affected modules and functionalities:

  • ImageDecoder*

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao jantonguirao changed the title Move old ImageDecoder to legacy module and make the nvImageCodec base… Move old ImageDecoder to legacy module and make the nvImageCodec based ImageDecoder the default Apr 25, 2024
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14518294]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14518294]: BUILD FAILED

…d ImageDecoder the default

Signed-off-by: Joaquin Anton <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14536354]: BUILD STARTED

@jantonguirao jantonguirao marked this pull request as ready for review April 26, 2024 09:06
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14538241]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14538241]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14538775]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14539149]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14539370]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14539149]: BUILD FAILED

@jantonguirao jantonguirao force-pushed the legacy_image_dec branch 2 times, most recently from a4deece to eefc26d Compare April 26, 2024 10:54
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14539370]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14539920]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14539920]: BUILD FAILED

Signed-off-by: Joaquin Anton <[email protected]>
Signed-off-by: Joaquin Anton <[email protected]>
@jantonguirao jantonguirao force-pushed the legacy_image_dec branch 2 times, most recently from e2e447c to 7240e83 Compare May 8, 2024 15:01
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14848436]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14848436]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14850230]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14851029]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14856666]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14856666]: BUILD FAILED

Signed-off-by: Joaquin Anton <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14873790]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14873790]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14878610]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14880652]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14880652]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14880652]: BUILD PASSED

@jantonguirao jantonguirao merged commit da8204c into NVIDIA:main May 9, 2024
jantonguirao added a commit to jantonguirao/DALI that referenced this pull request May 13, 2024
…dec based ImageDecoder the default (NVIDIA#5445)"

This reverts commit da8204c.
jantonguirao added a commit that referenced this pull request May 13, 2024
…dec based ImageDecoder the default (#5445)" (#5464)

This reverts commit da8204c.
stiepan pushed a commit that referenced this pull request May 13, 2024
…dec based ImageDecoder the default (#5445)" (#5464)

This reverts commit da8204c.
jantonguirao added a commit to jantonguirao/DALI that referenced this pull request May 15, 2024
…vImageCodec based ImageDecoder the default (NVIDIA#5445)""

This reverts commit a1b4fbd.

Signed-off-by: Joaquin Anton <[email protected]>
jantonguirao added a commit to jantonguirao/DALI that referenced this pull request May 15, 2024
…vImageCodec based ImageDecoder the default (NVIDIA#5445)""

This reverts commit a1b4fbd.

Signed-off-by: Joaquin Anton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants