Update of FFmpeg to n7.1 #5681
Update of FFmpeg to n7.1 #5681
Conversation
Signed-off-by: Marek Dabek <[email protected]>
Signed-off-by: Marek Dabek <[email protected]>
|
CI MESSAGE: [19443779]: BUILD STARTED |
|
CI MESSAGE: [19443779]: BUILD FAILED |
|
CI MESSAGE: [19446408]: BUILD STARTED |
|
CI MESSAGE: [19460045]: BUILD STARTED |
|
CI MESSAGE: [19446408]: BUILD PASSED |
|
CI MESSAGE: [19460045]: BUILD PASSED |
| @@ -527,6 +527,7 @@ void FramesDecoder::SeekFrame(int frame_id) { | |||
|
|
|||
| // Seeking clears av buffers, so reset flush state info | |||
| if (flush_state_) { | |||
| while (ReadFlushFrame(nullptr, false)) {} | |||
There was a problem hiding this comment.
Why does it help or what was wrong with it before?
There was a problem hiding this comment.
Apparently avcodec_flush_buffers doesn't clean decoder buffers properly anymore, and when we switch to the next file there are frames left in the buffer, and we cannot feed more frames to the decoder without reading them first. So this is an additional mechanism to clean the decoder output buffer as avcodec_flush_buffers (or the particular decoder implementation that should do that) doesn't fully work as we expect anymore. When works it should be noop.
There was a problem hiding this comment.
I wish we could narrow it down to a particular change in the codec...
Category:
Other - dependency update
Description:
Dependency update to FFmpeg n7.1
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A
DALI-4077