Skip to content

Remove libavutils from the asan suppression list #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jan 16, 2025

  • removes libavutils from the asan suppression list
  • keeps suppression for FFmpegDemuxer from the PyNvVideoCodec
    DALI doesn't have control on
  • fixes leaks from libavutils

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • removes libavutils from the asan suppression list
  • keeps suppression for FFmpegDemuxer from the PyNvVideoCodec
    DALI doesn't have control on
  • fixes leaks from libavutils

Additional information:

Affected modules and functionalities:

  • asan suppression list
  • frames decoder
  • video reader

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • sanitized build
    • test_video.py
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22576517]: BUILD STARTED

exit 1
fi

DALI_USE_EXEC2=0 "$FULLPATH"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen when executor 2.0 will become default one? Will this test fail and would need to be fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by mistake. Removed.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22576517]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22591547]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22591547]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22616313]: BUILD STARTED

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22624403]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22624403]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22637387]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22637387]: BUILD FAILED

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22656269]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22656269]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [22656269]: BUILD PASSED

@JanuszL JanuszL merged commit a4d8987 into NVIDIA:main Jan 20, 2025
6 checks passed
@JanuszL JanuszL deleted the av_leaks branch January 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants