Skip to content

Relax DisplacementTest.Sphere constraints from 0.005 to 0.006 #5821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Feb 17, 2025

  • due to differences in computations for some arches relax tests
    constraints to make sure it passes

We need a few more information from you to proceed.
Please fill the relevant sections in this PR template.

Fields in the Checklist section can be marked after you create and save the Pull Request.
--->

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • due to differences in computations for some arches relax tests
    constraints to make sure it passes

Additional information:

Affected modules and functionalities:

  • DisplacementTest.Sphere

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • DisplacementTest.Sphere
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- due to differences in computations for some arches relax tests
  constraints to make sure it passes

Signed-off-by: Janusz Lisiecki <[email protected]>
@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 17, 2025

!build

@JanuszL JanuszL marked this pull request as ready for review February 17, 2025 07:24
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24055866]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24055990]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24055866]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24055990]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24055866]: BUILD PASSED

@mzient mzient assigned mzient and unassigned banasraf Feb 18, 2025
@mzient mzient merged commit 01f8209 into NVIDIA:main Feb 18, 2025
7 checks passed
@JanuszL JanuszL deleted the relax_sphere branch February 18, 2025 11:17
5had3z pushed a commit to 5had3z/DALI that referenced this pull request Feb 23, 2025
…#5821)

- due to differences in computations for some archs, relax tests constraints to make sure it passes

Signed-off-by: Janusz Lisiecki <[email protected]>
5had3z pushed a commit to 5had3z/DALI that referenced this pull request Feb 23, 2025
…#5821)

- due to differences in computations for some archs, relax tests constraints to make sure it passes

Signed-off-by: Janusz Lisiecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants