Enhanced Video Codec Support and Error Handling #5825
Merged
+223
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes sure that the GPU video decoding capabilities are not affected by codecs supported on the CPU - retains from CPU video codec initialization on the CPU for the experimental video reader Signed-off-by: Janusz Lisiecki <[email protected]>
|
!build |
|
CI MESSAGE: [24339468]: BUILD STARTED |
JanuszL
changed the title
mzient
reviewed
Feb 21, 2025
| "vp8", | ||
| "vp9", | ||
| "mpeg4", | ||
| ] # av1 and mpeg4 are not supported by now |
There was a problem hiding this comment.
Unclear comment: mpeg4 is listed above, av1 isn't - so what does it mean?
Signed-off-by: Janusz Lisiecki <[email protected]>
|
!build |
|
CI MESSAGE: [24343878]: BUILD STARTED |
mzient
approved these changes
Feb 21, 2025
Signed-off-by: Joaquin Anton Guirao <[email protected]>
jantonguirao
approved these changes
Feb 21, 2025
|
CI MESSAGE: [24347657]: BUILD STARTED |
jantonguirao
changed the title
JanuszL
commented
Feb 21, 2025
| if (!FindVideoStream(init_codecs || build_index)) { | ||
| return; | ||
| if (build_index) { | ||
| init_codecs = true; // for the sake of build_index, we need to init the codecs |
There was a problem hiding this comment.
Can you explain? I though that it is enough to read the packets without having the codec initialized?
There was a problem hiding this comment.
OK, it wasn't necessary after all. I cleaned this up
|
CI MESSAGE: [24347657]: BUILD FAILED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
Signed-off-by: Joaquin Anton Guirao <[email protected]>
JanuszL
commented
Feb 21, 2025
|
CI MESSAGE: [24350975]: BUILD STARTED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Joaquin Anton Guirao <[email protected]>
|
CI MESSAGE: [24339468]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [24362754]: BUILD STARTED |
|
CI MESSAGE: [24350975]: BUILD PASSED |
|
CI MESSAGE: [24362754]: BUILD FAILED |
|
CI MESSAGE: [24362754]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix / Refactoring
Description:
This PR improves the video decoder's codec support detection and error handling, particularly for cases where CPU codec support is not available.
GetAllStreamInfo()method to provide detailed stream information for debuggingReadNextFrameinterface to use nullptr for skipping framescopy_to_outputparameter from frame reading methodsAdditional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A