Skip to content

Fix test array unique ptr #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Mar 4, 2025

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

Fixes the mismatched new[] / delete in C data_objects_test.

Additional information:

Tested with valgrind. The errors went away after this fix.

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@mzient mzient force-pushed the fix_test_array_unique_ptr branch from 4b63953 to 084433a Compare March 4, 2025 14:33
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24873377]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Mar 4, 2025
@JanuszL JanuszL self-assigned this Mar 4, 2025
@NVIDIA NVIDIA deleted a comment from dali-automaton Mar 4, 2025
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24874370]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24875156]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24875156]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24875156]: BUILD PASSED

@mzient mzient merged commit 60ecbc4 into NVIDIA:main Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants