Skip to content

Bump up support TF version to 2.18 #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Bump up support TF version to 2.18 #5840

merged 1 commit into from
Mar 12, 2025

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 6, 2025

  • removes build in support for 2.16.x (still the plugin can be compiled on the fly)
  • bumps TF 2.17.0 -> 2.17.1
  • adds TF 2.18 support
  • adjust TF version detection for the most recent TF version -
    different include file needs to be used

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • removes build in support for 2.16.x (still the plugin can be compiled on the fly)
  • bumps TF 2.17.0 -> 2.17.1
  • adds TF 2.18 support
  • adjust TF version detection for the most recent TF version -
    different include file needs to be used

Additional information:

Affected modules and functionalities:

  • setup_pacakges
  • DALI TF plugin

Key points relevant for the review:

Tests:

  • Existing tests apply
    • all TF related tests
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25004734]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25012805]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25012973]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25004734]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25012973]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25012805]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25012805]: BUILD PASSED

- removes build in support for 2.16.x (still the plugin can be compiled on the fly)
- bumps TF 2.17.0 -> 2.17.1
- adds TF 2.18 support
- adjust TF version detection for the most recent TF version -
  version is extracted from python and passed to the compilation cmd

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25057135]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25057135]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25062534]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25062534]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25078109]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25062534]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25078109]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25078109]: BUILD PASSED

@JanuszL JanuszL merged commit e4a5b11 into NVIDIA:main Mar 12, 2025
6 checks passed
@JanuszL JanuszL deleted the tf_2_18 branch March 12, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants