Skip to content

Fix data race in experimental image decoder #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

jantonguirao
Copy link
Contributor

Category:

Bug fix

Description:

  • Fixes a rare data corruption issue observed in experimental image decoder.
  • Added a WaitForWork at the end of RunImpl in image decoder, which makes sure that nvimagecodec is done using our thread pool executor.
  • nvimagecodec currently has a bug that sets the promise for the batch before it has issued stream synchronization with the user stream. Adding WaitForWork forces us to wait for it to finish.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • [x ] N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao jantonguirao force-pushed the fix_nvimagecodec_bug branch 2 times, most recently from c07f81b to dacfbb5 Compare March 21, 2025 13:43
@jantonguirao
Copy link
Contributor Author

!build

@jantonguirao jantonguirao force-pushed the fix_nvimagecodec_bug branch from dacfbb5 to 3f76586 Compare March 21, 2025 13:47
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25842431]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25842431]: BUILD FAILED

@jantonguirao jantonguirao force-pushed the fix_nvimagecodec_bug branch from 3f76586 to b0cf40e Compare March 21, 2025 18:12
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25852093]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [25852093]: BUILD FAILED

@jantonguirao jantonguirao merged commit 3a6b103 into NVIDIA:main Mar 24, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants