Add fallback for missing source info in check_batch #5861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [26057779]: BUILD STARTED |
mzient
reviewed
Mar 26, 2025
dali/test/python/test_utils.py
Outdated
| @@ -351,7 +351,10 @@ def _verify_batch_size(batch): | |||
| if hasattr(batch2[i], "source_info"): | |||
| error_msg += f"\nRHS data source: {batch2[i].source_info()}" | |||
|
|
|||
| dump_as_core_artifacts(batch1[i].source_info(), left, right, sample_idx=i) | |||
| filename = ( | |||
| batch1[i].source_info() if hasattr(batch1[i], "source_info") else f"'unknown{i}" | |||
There was a problem hiding this comment.
Suggested change
| batch1[i].source_info() if hasattr(batch1[i], "source_info") else f"'unknown{i}" | |
| batch1[i].source_info() if hasattr(batch1[i], "source_info") else f"unknown{i}" |
- When dumping core artifacts in check_batch, handle cases where source_info is not available by using a fallback filename with the sample index. Signed-off-by: Janusz Lisiecki <[email protected]>
|
!build |
mzient
approved these changes
Mar 26, 2025
|
CI MESSAGE: [26058103]: BUILD STARTED |
|
CI MESSAGE: [26058103]: BUILD FAILED |
|
CI MESSAGE: [26058103]: BUILD PASSED |
mdabek-nvidia
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is not available by using a fallback filename with the sample index.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
is not available by using a fallback filename with the sample index.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
dump_as_core_artifactsChecklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A