Skip to content

Remove unnecessary global declarations and add noqa comments #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 31, 2025

  • Remove redundant global declarations where not needed
  • Add noqa: F824 comments to suppress linter warnings forglobal/nonlocal variables
    in autograph test where it is done on purpose

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • Remove redundant global declarations where not needed
  • Add noqa: F824 comments to suppress linter warnings forglobal/nonlocal variables
    in autograph test where it is done on purpose

Additional information:

Affected modules and functionalities:

  • autograph (mostly)

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • linter run
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- Remove redundant global declarations where not needed
- Add noqa: F824 comments to suppress linter warnings forglobal/nonlocal variables
  in autograph test where it is done on purpose

Signed-off-by: Janusz Lisiecki <[email protected]>
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 31, 2025

!build

@awolant awolant self-assigned this Mar 31, 2025
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [26207924]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [26207924]: BUILD PASSED

@JanuszL JanuszL merged commit 24fd74d into NVIDIA:main Apr 1, 2025
7 checks passed
@JanuszL JanuszL deleted the fix_flak8 branch April 1, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants