C API 2.0: External source info #5872
Conversation
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
force-pushed
the
c_api2_external_source_info
branch
from
b594d9b to
8d11321
Compare
|
CI MESSAGE: [26640097]: BUILD STARTED |
|
CI MESSAGE: [26640097]: BUILD PASSED |
| * | ||
| * @param pipeline [in] The pipeline | ||
| * @param out_input_desc [out] A pointer to the location where the descriptor is written. | ||
| * @param name [in] The name of the input whose descriptor to obtain.] |
There was a problem hiding this comment.
| * @param name [in] The name of the input whose descriptor to obtain.] | |
| * @param name [in] The name of the input whose descriptor to obtain. |
There was a problem hiding this comment.
Will fix in upcoming PR.
| * @retval DALI_SUCCESS | ||
| * @retval DALI_ERROR_INVALID_OPERATION the pipeline wasn't built before the call | ||
| */ | ||
| DALI_API daliResult_t daliPipelineGetInputCount(daliPipeline_h pipeline, int *out_input_count); |
There was a problem hiding this comment.
| DALI_API daliResult_t daliPipelineGetInputCount(daliPipeline_h pipeline, int *out_input_count); | |
| DALI_API daliResult_t daliPipelineGetInputCount(daliPipeline_h pipeline, int *out_input_count); |
The out_input seems a bit confusing name at first. Why not just input_count? Does the out_ prefix relate to the fact this is the output of this function?
There was a problem hiding this comment.
Or it rephrases the type of the argument? If that's not a convention of the API to mark output arguments (I don't recall we have such convention), I'd avoid alluding to the type of the desc class in the name and go with simpler input_count.
There was a problem hiding this comment.
Yes, I noticed this, too. It's used throughout the header this way and yes, all output parameters are prefixed with out_.
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR adds the ability to query for external source descriptors that contain:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4240