Skip to content

Experimental: remove squeezing from C API #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Apr 23, 2025

Category:

Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

This PR removes the feature of squeezing the innermost dimension in C API.

  1. We didn't use it in TF for dense tensors (and sparse tensors weren't even tested until very recently)
  2. It can easily break by coincidence
  3. It was already broken for scalar outputs and we didn't even notice.

Formally it's a breaking change, affecting sparse tensors in TF plugin (which we don't really care about) and Triton (where we don't really process data that would undergo this squeeze).

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

Tensorflow tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27391731]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27391731]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27391731]: BUILD PASSED

@mzient mzient force-pushed the c_api_dont_squeeze branch from 6fa5da1 to e6c20f7 Compare April 24, 2025 08:32
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27436168]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27436168]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27436168]: BUILD PASSED

@mzient mzient merged commit fd67161 into NVIDIA:main Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants