Migrate DALI TF plugin to C API 2.0 #5904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [27754656]: BUILD STARTED |
mzient
force-pushed
the
c_api2_tf_plugin
branch
from
17a4d10 to
adc5473
Compare
|
CI MESSAGE: [27755682]: BUILD STARTED |
|
CI MESSAGE: [27755682]: BUILD PASSED |
jantonguirao
approved these changes
May 2, 2025
rostan-t
approved these changes
May 2, 2025
dali_tf_plugin/dali_dataset_op.cc
Outdated
Comment on lines
305
to
306
| params.exec_type_present = 1; | ||
| params.exec_type = exec_type; |
There was a problem hiding this comment.
DALI_SET_PARAM could be used there
- change stubgen to point to dali.h - change stuben to use DALI_API instead of DLL_PUBLIC - rework error handling to use DALI error codes - use managed handles to avoid resource leaks Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [27945405]: BUILD STARTED |
|
CI MESSAGE: [27945405]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
This change abandons the (not really) C API in favor of C API 2.0 in Tensorflow plugin.
Additional information:
This change requires #5898.
Executor memory stats are not implemented in the new C API and the code that prints them is disabled. We can either remove the code or re-implement those in a follow-up.
Affected modules and functionalities:
DALI Tensorflow plugin
Key points relevant for the review:
Tests:
TF tests
TF L3 tests (RN50 and YOLO)
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A