Improve error messages in video loader with file name in the message #5910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
force-pushed
the
improve_video_reader_loging
branch
from
3e60fd5 to
d5c5c6a
Compare
|
!build |
|
CI MESSAGE: [27993386]: BUILD STARTED |
|
CI MESSAGE: [27993386]: BUILD PASSED |
jantonguirao
approved these changes
May 6, 2025
szkarpinski
requested changes
May 6, 2025
| } | ||
| auto stream = file.fmt_ctx_->streams[file.vid_stream_idx_]; | ||
| req.frame_base = file.frame_base_; | ||
|
|
||
| if (vid_decoder_) { | ||
| vid_decoder_->push_req(req); | ||
| } else { | ||
| DALI_FAIL("No video decoder even after opening a file"); | ||
| DALI_FAIL(make_string("No video decoder even after opening a file for file: ", req.filename)); |
There was a problem hiding this comment.
Suggested change
| DALI_FAIL(make_string("No video decoder even after opening a file for file: ", req.filename)); | |
| DALI_FAIL(make_string("No video decoder even after opening a file: ", req.filename)); |
- adds filename information to error messages in video_loader.cc to make debugging easier by by extending DALI_FAIL and DALI_ENFORCE error messages in the video loader Signed-off-by: Janusz Lisiecki <[email protected]>
Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
improve_video_reader_loging
branch
from
d5c5c6a to
d6958f6
Compare
|
!build |
|
CI MESSAGE: [28014855]: BUILD STARTED |
|
CI MESSAGE: [28014855]: BUILD FAILED |
szkarpinski
approved these changes
May 6, 2025
|
CI MESSAGE: [28014855]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easier by by extending DALI_FAIL and DALI_ENFORCE error messages in the video loader
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
easier by by extending DALI_FAIL and DALI_ENFORCE error messages in the video loader
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A