-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Make scaffolding Controller more generic #3408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
WeiHaocheng
added a commit
to WeiHaocheng/TensorRT-LLM
that referenced
this issue
Apr 9, 2025
Signed-off-by: fredw (generated by with_the_same_user script) <[email protected]>
WeiHaocheng
added a commit
to WeiHaocheng/TensorRT-LLM
that referenced
this issue
Apr 10, 2025
Signed-off-by: fredw (generated by with_the_same_user script) <[email protected]>
WeiHaocheng
added a commit
to WeiHaocheng/TensorRT-LLM
that referenced
this issue
Apr 10, 2025
Signed-off-by: fredw (generated by with_the_same_user script) <[email protected]>
WeiHaocheng
added a commit
to WeiHaocheng/TensorRT-LLM
that referenced
this issue
Apr 11, 2025
Signed-off-by: fredw (generated by with_the_same_user script) <[email protected]>
WeiHaocheng
added a commit
to WeiHaocheng/TensorRT-LLM
that referenced
this issue
Apr 12, 2025
Signed-off-by: fredw (generated by with_the_same_user script) <[email protected]>
WeiHaocheng
added a commit
that referenced
this issue
Apr 12, 2025
Signed-off-by: fredw (generated by with_the_same_user script) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to do some optimizations to make the Controller more generic, which will help with better modularity.
These changes will not affect the existing API.
`
We make the reward method in BestOfNController more generic as we observe that reward methods become various in recently paper and works.
We remove most of type check for Task as users may override them.
The text was updated successfully, but these errors were encountered: