Skip to content

feat: use cudaMalloc to allocate kvCache #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

chuangz0
Copy link
Collaborator

@chuangz0 chuangz0 commented Apr 6, 2025

use cudaMalloc to allocate kvCache , so kvCache pool can be register by transfer enigne

@chuangz0
Copy link
Collaborator Author

chuangz0 commented Apr 6, 2025

/bot run --add-multi-gpu-test

@chuangz0 chuangz0 requested a review from Shixiaowei02 April 6, 2025 05:35
@tensorrt-cicd
Copy link
Collaborator

PR_Github #1218 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1218 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #913 completed with status: 'FAILURE'

@juney-nvidia juney-nvidia changed the title use cudaMalloc to allocate kvCache feat: use cudaMalloc to allocate kvCache Apr 6, 2025
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Apr 6, 2025

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1226 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1226 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #919 completed with status: 'FAILURE'

@chuangz0 chuangz0 force-pushed the use_cudaMalloc_allocate_kvCache branch from fec79bd to c691394 Compare April 7, 2025 01:18
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Apr 7, 2025

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1247 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1247 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #939 completed with status: 'FAILURE'

@chuangz0 chuangz0 force-pushed the use_cudaMalloc_allocate_kvCache branch from 6a0dde7 to 7e00b7a Compare April 7, 2025 07:38
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Apr 7, 2025

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1290 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1290 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #972 completed with status: 'SUCCESS'

chuangz0 added 3 commits April 8, 2025 10:46
Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Chuang Zhu <[email protected]>
@Shixiaowei02 Shixiaowei02 force-pushed the use_cudaMalloc_allocate_kvCache branch from 7e00b7a to 70f5745 Compare April 8, 2025 02:46
@Shixiaowei02
Copy link
Collaborator

/bot reuse-pipeline

@Shixiaowei02 Shixiaowei02 enabled auto-merge (squash) April 8, 2025 02:47
@tensorrt-cicd
Copy link
Collaborator

PR_Github #1389 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1389 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #1290 for commit 70f5745

@Shixiaowei02 Shixiaowei02 merged commit 1c88af1 into NVIDIA:main Apr 8, 2025
2 checks passed
sarattha pushed a commit to sarattha/TensorRT-LLM that referenced this pull request Apr 9, 2025
tomeras91 pushed a commit to tomeras91/TensorRT-LLM that referenced this pull request Apr 9, 2025
tomeras91 pushed a commit to tomeras91/TensorRT-LLM that referenced this pull request Apr 9, 2025
@schetlur-nv
Copy link
Collaborator

@chuangz0 this change seems to be pretty general, and is not limited to disaggregated serving. Did we assess that using cudaMalloc does not affect other use-cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants