Skip to content

fix: fix partialMatch #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix: fix partialMatch #3413

merged 1 commit into from
Apr 11, 2025

Conversation

pansicheng
Copy link
Contributor

If other.uniqueTokens.end() is not passed, the second range will have std::distance(first1, last1) elements, potentially causing undefined behavior if other.uniqueTokens is smaller than this.uniqueTokens.

https://en.cppreference.com/w/cpp/algorithm/mismatch

@juney-nvidia juney-nvidia changed the title fix partialMatch fix: fix partialMatch Apr 9, 2025
@qsang-nv qsang-nv requested a review from kaiyux April 10, 2025 01:48
@kaiyux kaiyux requested review from Funatiq and thorjohnsen and removed request for kaiyux April 10, 2025 03:15
Copy link
Collaborator

@Funatiq Funatiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Funatiq
Copy link
Collaborator

Funatiq commented Apr 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1758 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1758 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1303 completed with status: 'SUCCESS'

@Funatiq Funatiq enabled auto-merge (squash) April 11, 2025 08:19
@Funatiq
Copy link
Collaborator

Funatiq commented Apr 11, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1899 [ reuse-pipeline ] triggered by Bot

Signed-off-by: pansicheng <[email protected]>
@kaiyux kaiyux force-pushed the fix-partialMatch branch from b6d5479 to 1d29df4 Compare April 11, 2025 08:30
@kaiyux
Copy link
Member

kaiyux commented Apr 11, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1899 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #1758 for commit b6d5479

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1901 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1901 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #1758 for commit 1d29df4

@Funatiq Funatiq merged commit 143edc8 into NVIDIA:main Apr 11, 2025
2 checks passed
@pansicheng pansicheng deleted the fix-partialMatch branch April 14, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants